Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13975] Spell check some typos accross the code base #56370

Closed
LucianoPAlmeida opened this issue Dec 19, 2020 · 3 comments
Closed

[SR-13975] Spell check some typos accross the code base #56370

LucianoPAlmeida opened this issue Dec 19, 2020 · 3 comments
Labels
good first issue Good for newcomers improvement

Comments

@LucianoPAlmeida
Copy link
Collaborator

Previous ID SR-13975
Radar None
Original Reporter @LucianoPAlmeida
Type Improvement
Status In Progress
Resolution
Additional Detail from JIRA
Votes 0
Component/s
Labels Improvement, StarterBug
Assignee aniketiq (JIRA)
Priority Medium

md5: dbf5a45167898cb420f8b7b745c5c0ac

Issue Description:

Recently started to use VSCodeSpellCheck extension https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker and while going through the code is possible to see some code/comments with minor typos. Some of them are just false positives, but others are actually words mistyped.

So the suggestion here would be to look file by file in VSCode with CodeSpellCheck and fix where it does make sense to. Or if someone knows a more automated way to do this ... feel free to suggest 🙂
@LucianoPAlmeida
Copy link
Collaborator Author

cc theindigamer (JIRA User) what do you think? a good starter task?

@typesanitizer
Copy link

I would be hesitant to have it change things automatically due to false positives, but fixing typos is generally okay.

@LucianoPAlmeida
Copy link
Collaborator Author

I agree, the main idea would be really to

  • Open the codebase in VisualStudioCode with CodeSpellCheck extension.

  • And browse to the files checking the occurrences that are really typos.

  • I think initially we could check mainly the Diagnostics{*}.def files as I have already seen that we may have some typos on user-facing diagnostics.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@typesanitizer @LucianoPAlmeida