Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-1402] Check dependency graph for possible collisions #5295

Closed
aciidgh opened this issue May 4, 2016 · 4 comments
Closed

[SR-1402] Check dependency graph for possible collisions #5295

aciidgh opened this issue May 4, 2016 · 4 comments
Labels
bug

Comments

@aciidgh
Copy link
Member

aciidgh commented May 4, 2016

Previous ID SR-1402
Radar rdar://problem/40206312
Original Reporter @aciidb0mb3r
Type Bug
Status Resolved
Resolution Cannot Reproduce
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: ecc718e3eb1f298a4f06d25f17822b2f

relates to:

  • SR-1168 Deal with dependency name collisions

Issue Description:

if an external dependency has a module name same as a module in root package the root package module is not compiled at all. This should probably error out with proper diagnostic message.
@ddunbar
Copy link
Member

ddunbar commented May 4, 2016

When you say external dependency, do you mean a system module package, or a regular module dependency in another Package?

@aciidgh
Copy link
Member Author

aciidgh commented May 4, 2016

using the terminology from fixtures/DependencyResolution -> regular module dependency in another package.

@abertelrud
Copy link
Contributor

Seems related to SR-1168

@aciidgh
Copy link
Member Author

aciidgh commented Jul 27, 2018

We're able to correctly detect such collisions:

error: multiple targets named 'foo' in: bar, foo

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddunbar @aciidgh @abertelrud