New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-14042] Fix differentiable function reabstraction and re-enable tests #56433
Comments
I'll re-pitch the idea of creating a top-level This representation is much less memory-efficient and harder to parse and printing. But it is explicit, so all of these reabstraction and "conservation" and phase ordering (commutative diagram) issues. The current representation implicitly infers JVP & VJP function types (particularly the differential and pullback types) from the original function type's parameter and result conventions. It may be possible to fix all the bugs here: so that the inference is consistent everywhere, respecting phase ordering, working for both |
@swift-ci create |
IMO that is an overly heavyweight solution and will explore other possible approaches. |
That's fair. Look forward to more elegant ideas, happy to discuss! |
I think the lightweighter version of the idea above is storing |
Yes, that's exactly what I had planned to try. Currently we have |
Additional Detail from JIRA
md5: 1d4a7be8650ea72475f9157c628e8d7d
relates to:
differentiable_function
and SIL diff witnesses@differentiable
functionsIssue Description:
There are runtime crashes related to differentiable function reabstraction in SIL not working properly. These issues aren't caught in SIL verification because `@differentiable`-function-type-related instruction verification is also disabled: TF-1197.
Some related tests are disabled in #35384 This issue tracks landing a robust fix for the reabstraction-related issues and re-enabling the tests.
The text was updated successfully, but these errors were encountered: