Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14087] Make AutoDiff work well with substituted SIL function types #54769

Open
dan-zheng opened this issue Mar 10, 2020 · 1 comment
Open

[SR-14087] Make AutoDiff work well with substituted SIL function types #54769

dan-zheng opened this issue Mar 10, 2020 · 1 comment
Assignees
@rxwei
Labels
AutoDiff bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@dan-zheng
Copy link
Collaborator

Previous ID SR-14087
Radar rdar://problem/73507238
Original Reporter @dan-zheng
Type Bug
Additional Detail from JIRA
Votes 0
Component/s
Labels Bug
Assignee @rxwei
Priority Medium

md5: 848257f813726327abe57270c02f8c6a

Sub-Tasks:

  • SR-14088 Re-enable SIL verification for differentiable_function and SIL diff witnesses
  • SR-14089 Fix mapTypeOutOfContext hack in applyTrivialConversions in SILGenPoly.cpp

Issue Description:

Substituted SIL function types caused many AutoDiff breakages on tensorflow branch.

Fixing breakages took over a week.
This issue tracks incremental AutoDiff fixes/improvements after the initial fix.
@rxwei
Copy link
Member

rxwei commented Jan 22, 2021

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rxwei rxwei

Labels
AutoDiff bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rxwei @BradLarson @dan-zheng