Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14737] Missing argument label completion for generic initializer inside closure #57087

Closed
ahoppen opened this issue Jun 8, 2021 · 2 comments · Fixed by #38044
Closed

[SR-14737] Missing argument label completion for generic initializer inside closure #57087

ahoppen opened this issue Jun 8, 2021 · 2 comments · Fixed by #38044
Assignees
@rintaro
Labels
argument labels Feature: function argument labels bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. call expressions Feature → expressions: Call expressions closures Feature: closures code completion Area → source tooling: code completion expressions Feature: expressions found by stress tester Flag: An issue found by the SourceKit stress tester source tooling Area: IDE support, SourceKit, and other source tooling unexpected behavior Bug: Unexpected behavior or incorrect output

Comments

@ahoppen
Copy link
Contributor

ahoppen commented Jun 8, 2021 •
edited by AnthonyLatsis

Previous ID SR-14737
Radar rdar://problem/79092374
Original Reporter @ahoppen
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s CodeCompletion
Labels Bug, FoundByStressTester
Assignee @rintaro
Priority Medium

md5: 2d08989172c8e74d199cce680bb46a1c

relates to:

Issue Description:

In the following test case the isActive argument label is not suggested. When removing the x.map closure around it, the argument label is properly completed.

// RUN: %swift-ide-test --code-completion --source-filename %s --code-completion-token=COMPLETE

struct TodayView {
    var x {
        let x = Bool?
        x.map { _ in
            NavigationLink2(destination: true, #^COMPLETE^#isActive: true)
        }
    }
}

public struct NavigationLink2<Label> {
    public init(destination: Label, isActive: Bool) { fatalError() }
}
@typesanitizer
Copy link

@swift-ci create

@ahoppen
Copy link
Contributor Author

ahoppen commented Aug 3, 2021

Fixed by #38044

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added the source tooling Area: IDE support, SourceKit, and other source tooling label Feb 6, 2023
@AnthonyLatsis AnthonyLatsis added the unexpected behavior Bug: Unexpected behavior or incorrect output label Nov 24, 2023
This was referenced Nov 24, 2023
Closed
Merged
@AnthonyLatsis AnthonyLatsis added argument labels Feature: function argument labels call expressions Feature → expressions: Call expressions expressions Feature: expressions closures Feature: closures labels Nov 24, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rintaro rintaro

Labels
argument labels Feature: function argument labels bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. call expressions Feature → expressions: Call expressions closures Feature: closures code completion Area → source tooling: code completion expressions Feature: expressions found by stress tester Flag: An issue found by the SourceKit stress tester source tooling Area: IDE support, SourceKit, and other source tooling unexpected behavior Bug: Unexpected behavior or incorrect output
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CodeCompletion] Allow unresolved types in Callee analysis rintaro/swift
3 participants
@ahoppen @typesanitizer @AnthonyLatsis