[SR-15111] “Type of expression is ambiguous” error when initializing a class #57437

swift-ci · 2021-08-25T08:31:58Z


Previous ID	SR-15111
Radar	rdar://problem/82407752
Original Reporter	elidy (JIRA User)
Type	Bug

Environment

Xcode Version 13.0 beta 4 (13A5201i)

Additional Detail from JIRA


Votes	0
Component/s	Compiler
Labels	Bug, DiagnosticsQoI, StarterBug, TypeChecker
Assignee	elidy (JIRA)
Priority	Medium

md5: 37c1160eb7b2424ea42b3ec849906fef

Issue Description:

When a class is initialized, passing an argument as a property of an optional class instance of incorrect type results in “Type of expression is ambiguous” error.

 class IntClass {
    var int: Int?
    
    init(int: Int?) {
        self.int = int
    }
}

class StringClass {
    var string: String? = "hello"
}

var stringClass: StringClass? = StringClass()

IntClass(int: stringClass?.string)
//Type of expression is ambiguous without more context
//Expected error: Cannot convert value of type 'String?' to expected argument type 'Int?'

var stringValue = stringClass?.string
IntClass(int: stringValue)
//Cannot convert value of type 'String?' to expected argument type 'Int?'

typesanitizer · 2021-08-26T22:25:42Z

@swift-ci create

xedin · 2021-08-30T17:36:03Z

elidy (JIRA User) I see that you are assigned for this one, here is a hint - in repairFailures for GenericArgument we could check whether previous element is an ApplyArgToParam and if so record a AllowArgumentMismatch fix.

LucianoPAlmeida · 2021-09-01T03:27:49Z

@xedin Just an addition, this should be also the case for contextual type as well, for example let _: Int? = stringClass?.string

xedin · 2021-09-01T03:29:59Z

Sure, if ApplyArgToParam -> AllowArgumentMismatch fix, if ContextualType -> IgnoreContextualMismatch fix.

pedromotita · 2023-04-20T20:07:28Z

Hello @LucianoPAlmeida are you still working on this issue?

First time contributor here, and got interested in this one. Any insights you could give me?

AnthonyLatsis · 2023-04-20T23:39:48Z

Reduced set of test cases:

struct S {
  var str: String
}

func test(s: S?) {
  let _: Int? = s?.str

  func f(_: Int?) {}
  f(s?.str)
}

Environment update: Swift version 5.9-dev (LLVM 91080e65df791d6, Swift c1d5118)

LucianoPAlmeida · 2023-04-21T01:24:24Z

Hello @LucianoPAlmeida are you still working on this issue?

I actually forgot about this one 😆
If you want to take it go for it =]

First time contributor here, and got interested in this one. Any insights you could give me?

I think is exactly what @xedin mentioned in previous comments.

Rajveer100 · 2023-08-30T11:31:54Z

elidy (JIRA User) I see that you are assigned for this one, here is a hint - in repairFailures for GenericArgument we could check whether previous element is an ApplyArgToParam and if so record a AllowArgumentMismatch fix.

@xedin
I suppose you meant the diagnoseFailureFor(...) which is where the type_of_expression_is_ambiguous is called.
If that's the case, we probably check for the condition as you mentioned earlier here?

xedin · 2023-08-30T18:01:00Z

No, we need this diagnosed in repairFailures, diagnoseFailureFor contains only fallback logic for cases were a fix hasn't been emitted.

Rajveer100 · 2023-08-31T19:22:48Z

Also, if I understand correctly, the last two elements of path refer to the fromType and toType, and they need to exist in order to call the diagnostic, or precisely add to conversionsOrFixes?

xedin · 2023-08-31T20:53:11Z

Yes, the fixes are produced based on the failing constraint, repairFailures gets the types, the constraint and its location passed by the caller, repairFailures checks what does the location (identified by a locator) represent and based on that emits an appropriate fix, you can take a look at a few other case statements in repairFailures to better understand what is going on there, some of them a quite small.

… optional class instance (apple#57437)

LucianoPAlmeida · 2023-09-01T13:01:36Z

@pedromotita Are you still working on this? @Rajveer100 started a PR, so if not actively working on it can we change the assignee for this issue?

… optional class instance (apple#57437)

pedromotita · 2023-09-01T13:36:51Z

Already removed myself as the assignee. Keep on keeping on @Rajveer100 👍 😉

… optional class instance (apple#57437)

swift-ci transferred this issue from apple/swift-issues Apr 25, 2022

LucianoPAlmeida self-assigned this Jun 24, 2022

AnthonyLatsis added swift 5.9 type inference Feature: type inference optional chaining Feature → expressions: optional chaining expressions Feature: expressions labels Apr 20, 2023

LucianoPAlmeida assigned pedromotita and unassigned LucianoPAlmeida Apr 21, 2023

xedin mentioned this issue May 8, 2023

[Sema] Fix issue 65330 Unhelpful error when missing contextually requ… #65610

Merged

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Sep 1, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

de00dc6

… optional class instance (apple#57437)

Rajveer100 linked a pull request Sep 1, 2023 that will close this issue

[Sema] Improves diagnostic when passing an argument as property of an optional class instance (#57437) #68264

Open

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Sep 1, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

3ad2fc6

… optional class instance (apple#57437)

pedromotita removed their assignment Sep 1, 2023

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Sep 1, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

71f1a65

… optional class instance (apple#57437)

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Sep 1, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

99ac378

… optional class instance (apple#57437)

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Sep 2, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

89ab678

… optional class instance (apple#57437)

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Sep 11, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

a5e35fa

… optional class instance (apple#57437)

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Oct 12, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

b5a7cec

… optional class instance (apple#57437)

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Oct 12, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

bf123ea

… optional class instance (apple#57437)

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Nov 7, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

37831ac

… optional class instance (apple#57437)

Rajveer100 added a commit to Rajveer100/swift that referenced this issue Nov 14, 2023

[Sema] Improves diagnostic when passing an argument as property of an…

7be242a

… optional class instance (apple#57437)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SR-15111] “Type of expression is ambiguous” error when initializing a class #57437

[SR-15111] “Type of expression is ambiguous” error when initializing a class #57437

swift-ci commented Aug 25, 2021

typesanitizer commented Aug 26, 2021

xedin commented Aug 30, 2021 •

edited by AnthonyLatsis

LucianoPAlmeida commented Sep 1, 2021 •

edited by AnthonyLatsis

xedin commented Sep 1, 2021 •

edited by AnthonyLatsis

pedromotita commented Apr 20, 2023

AnthonyLatsis commented Apr 20, 2023

LucianoPAlmeida commented Apr 21, 2023

Rajveer100 commented Aug 30, 2023 •

edited

xedin commented Aug 30, 2023

Rajveer100 commented Aug 31, 2023

xedin commented Aug 31, 2023

LucianoPAlmeida commented Sep 1, 2023

pedromotita commented Sep 1, 2023

[SR-15111] “Type of expression is ambiguous” error when initializing a class #57437

[SR-15111] “Type of expression is ambiguous” error when initializing a class #57437

Comments

swift-ci commented Aug 25, 2021

typesanitizer commented Aug 26, 2021

xedin commented Aug 30, 2021 • edited by AnthonyLatsis

LucianoPAlmeida commented Sep 1, 2021 • edited by AnthonyLatsis

xedin commented Sep 1, 2021 • edited by AnthonyLatsis

pedromotita commented Apr 20, 2023

AnthonyLatsis commented Apr 20, 2023

LucianoPAlmeida commented Apr 21, 2023

Rajveer100 commented Aug 30, 2023 • edited

xedin commented Aug 30, 2023

Rajveer100 commented Aug 31, 2023

xedin commented Aug 31, 2023

LucianoPAlmeida commented Sep 1, 2023

pedromotita commented Sep 1, 2023

xedin commented Aug 30, 2021 •

edited by AnthonyLatsis

LucianoPAlmeida commented Sep 1, 2021 •

edited by AnthonyLatsis

xedin commented Sep 1, 2021 •

edited by AnthonyLatsis

Rajveer100 commented Aug 30, 2023 •

edited