Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-15430] SwiftPM: mirror entries are matched literally and doesn't account for the optional suffix #4378

Open
swift-ci opened this issue Nov 3, 2021 · 1 comment
Open

[SR-15430] SwiftPM: mirror entries are matched literally and doesn't account for the optional suffix #4378

swift-ci opened this issue Nov 3, 2021 · 1 comment
Labels
bug

Comments

@swift-ci
Copy link
Contributor

swift-ci commented Nov 3, 2021

Previous ID SR-15430
Radar None
Original Reporter michael.fagan (JIRA User)
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: ee9d43271ea738b1d446ac5faa8fe6c7

relates to:

  • SR-2917 Handle different URLs referring same package

Issue Description:

Dependency urls allow the suffix (`.git`) to be left off, however mirror entries appear to be matched literally.

If the same package is specified both ways in the dependency tree

some-package:
   depends on "https://.../Problem"
   depends on "sub-package"

sub-package:
   depends on "https://.../Problem.git"

would require both mirror entries to resolve and build

swift package config set-mirror -original-url "https://.../Problem.git" --mirror-url "internal/Solution.git"
swift package config set-mirror -original-url "https://.../Problem" --mirror-url "internal/Solution.git"
@mickeyl
Copy link

mickeyl commented Dec 23, 2021

Some more details can be found in https://forums.swift.org/t/spm-unconditionally-walks-the-dependency-tree/

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomerd @mickeyl @swift-ci