-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SR-1560] Implement support for SE-0075: Adding a Build Configuration Import Test #44169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Concerns about implementation, for anyone taking this on: 1. Currently, all 2. Parsing must not resolve imports, because we use parsing to do simple and fast syntax highlighting that should be useful even in the presence of source errors. I think this means the best approach is allowing |
Implementation so far is here (master...CodaFi:fine-imported-goods). Down to just some failing IDE tests! |
Is this still a candidate for Swift 4? |
No one was able to spend more time on it since Robert's initial implementation was found to be flawed. At this point that means it probably won't make Swift 4 either. |
@rintaro Is making good progress with the refactoring around this. The hardest part here is going to be lazier evaluation of conditions and rebinding declrefs that are shadowed by the introduction of variables in a condition. The latter problem could be solved by removing inner decl refs from the scope map and, when we evaluate the condition, run a walker that rebinds just those decl refs in our scope. It would have to be done in Sema, before or during the initial phase of type checking |
After speaking with Ben, we came up with a compromise. See #11613 |
Resolved by the merger of the previously linked pull request. |
Additional Detail from JIRA
md5: 04d04fe990aa65b2fa375f915f803045
relates to:
Issue Description:
"SE-0075: Adding a Build Configuration Import Test" has been accepted, an implementation would be great.
The text was updated successfully, but these errors were encountered: