Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SymbolGraphGen] swift-symbolgraph-extract support for emitting symbols from @_export imports #59920

Closed
franklinsch opened this issue Feb 28, 2022 · 1 comment · Fixed by #73080
Closed

[SymbolGraphGen] swift-symbolgraph-extract support for emitting symbols from @_export imports #59920

franklinsch opened this issue Feb 28, 2022 · 1 comment · Fixed by #73080
Labels
attributes Feature: Declaration and type attributes compiler The Swift compiler in itself @_exported Feature → attributes: the @_exported attribute feature A feature request or implementation import Feature → declarations: `import` declarations legacy driver Area → compiler: the integrated C++ legacy driver. Succeeded by the swift-driver project swift-symbolgraph-extract Area → compiler → legacy driver: the 'swift-symbolgraph-extract' mode SymbolGraphGen The swiftSymbolGraphGen library, responsible for gathering and emitting symbol graphs.

Comments

@franklinsch
Copy link
Member

franklinsch commented Feb 28, 2022 •
edited by AnthonyLatsis

Previous ID SR-15921
Radar rdar://problem/89687175
Original Reporter @franklinsch
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Swift-DocC
Labels Improvement
Assignee None
Priority Medium

md5: 3bcd4958d4ed4ce5d66606c682cf8647

Issue Description:

In apple/swift-docc#190, we started exporting symbols that came from @_exported import modules when emitting symbol graph files during a Swift build. This ticket tracks adding the same support for the swift-symbolgraph-extract, which didn't come for free with apple/swift-docc#190.
@QuietMisdreavus QuietMisdreavus added the SymbolGraphGen The swiftSymbolGraphGen library, responsible for gathering and emitting symbol graphs. label Jul 6, 2022
@QuietMisdreavus QuietMisdreavus mentioned this issue Jul 6, 2022
Merged
@QuietMisdreavus QuietMisdreavus mentioned this issue Sep 13, 2022
Merged
@stevapple
Copy link
Contributor

Is this going to be resolved? It’s causing some problems building the documentation with https://github.com/apple/swift-docc-plugin, which calls swift-symbol-extract through SwiftPM plugin host.

@AnthonyLatsis AnthonyLatsis added swift-symbolgraph-extract Area → compiler → legacy driver: the 'swift-symbolgraph-extract' mode compiler The Swift compiler in itself legacy driver Area → compiler: the integrated C++ legacy driver. Succeeded by the swift-driver project attributes Feature: Declaration and type attributes @_exported Feature → attributes: the @_exported attribute import Feature → declarations: `import` declarations bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. feature A feature request or implementation and removed bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. labels Apr 13, 2023
@d-ronnqvist d-ronnqvist changed the title [SR-15921] swift-symbolgraph-extract support for emitting symbols from @_export imports [SymbolGraphGen] swift-symbolgraph-extract support for emitting symbols from @_export imports Dec 21, 2023
daniel-grumberg added a commit to daniel-grumberg/swift that referenced this issue Apr 17, 2024
@daniel-grumberg
Recursively collect exported imports to allow fetching all visible De…
0246506 
…cls for symbol graph generation

This change is two fold. Firstly it enables collection of exported
imports from non source file units. Additionally this recurses through
the exported imports to ensure the transitive set is collected.

Fixes apple#59920
rdar://89687175
@daniel-grumberg daniel-grumberg mentioned this issue Apr 17, 2024
Merged
daniel-grumberg added a commit to daniel-grumberg/swift that referenced this issue Apr 18, 2024
@daniel-grumberg
Recursively collect exported imports to allow fetching all visible De…
1d749b1 
…cls for symbol graph generation

This change is two fold. Firstly it enables collection of exported
imports from non source file units. Additionally this recurses through
the exported imports to ensure the transitive set is collected.

Fixes apple#59920
rdar://89687175
daniel-grumberg added a commit to daniel-grumberg/swift that referenced this issue Apr 25, 2024
@daniel-grumberg
Recursively collect exported imports to allow fetching all visible De…
9964884 
…cls for symbol graph generation

This change is two fold. Firstly it enables collection of exported
imports from non source file units. Additionally this recurses through
the exported imports to ensure the transitive set is collected.

Fixes apple#59920
rdar://89687175
@daniel-grumberg daniel-grumberg mentioned this issue May 2, 2024
Open
This issue is being transferred. Timeline may not be complete until it finishes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attributes Feature: Declaration and type attributes compiler The Swift compiler in itself @_exported Feature → attributes: the @_exported attribute feature A feature request or implementation import Feature → declarations: `import` declarations legacy driver Area → compiler: the integrated C++ legacy driver. Succeeded by the swift-driver project swift-symbolgraph-extract Area → compiler → legacy driver: the 'swift-symbolgraph-extract' mode SymbolGraphGen The swiftSymbolGraphGen library, responsible for gathering and emitting symbol graphs.
Projects
None yet
Milestone
No milestone
4 participants
@QuietMisdreavus @franklinsch @AnthonyLatsis @stevapple