Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-1837] test/Runtime/backtrace.swift should be disabled on Android #44446

Open
modocache mannequin opened this issue Jun 20, 2016 · 0 comments
Open

[SR-1837] test/Runtime/backtrace.swift should be disabled on Android #44446

modocache mannequin opened this issue Jun 20, 2016 · 0 comments
Labels
Android Platform: Android good first issue Good for newcomers task

Comments

@modocache
Copy link
Mannequin

modocache mannequin commented Jun 20, 2016

Previous ID SR-1837
Radar None
Original Reporter @modocache
Type Task
Additional Detail from JIRA
Votes 0
Component/s
Labels Task, Android, StarterBug
Assignee None
Priority Medium

md5: 39669a7192d32d5afd9e59590d8db749

Issue Description:

As far as I recall, libunwind isn't available as part of the Android NDK, so the part of the Swift runtime that normally emits backtraces is ifdef'd out when compiling for Android. As a result, I assume the test/Runtime/backtrace.swift would almost certainly fail on Android – it should be disabled.

Prerequisites:

  • An Ubuntu 15.10 development environment capable of building Swift from source.

  • A physical Android device.

Helpful skills:
Basic knowledge of C++ would help, but isn't necessary.

Starting point:

  1. Follow the instructions in docs/Android.md to build and run the test suite on a physical Android device. Confirm this test still fails.

  2. Backtraces appear to be disabled on Android:

    #if defined(__CYGWIN__) || defined(__ANDROID__) || defined(_MSC_VER)
    # define SWIFT_SUPPORTS_BACKTRACE_REPORTING 0
    #else
    # define SWIFT_SUPPORTS_BACKTRACE_REPORTING 1
    #endif
    – Confirm this is still the case by reading through how that macro is used in that file.

  3. Read through test/Runtime/backtrace.swift, confirm that it does indeed test backtraces. If it does, add an unsupported: or requires: flag to the top of test/Runtime/backtrace.swift to keep it from running on platforms that don't support backtraces.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Platform: Android good first issue Good for newcomers task
Projects
None yet
Development

No branches or pull requests

0 participants