Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-2278] Add a validation test that makes sure overlay dependencies are correct #44885

Open
belkadan opened this issue Aug 4, 2016 · 0 comments
Labels
cmake SDKOverlay standard library Area: Standard library umbrella task

Comments

@belkadan
Copy link
Contributor

belkadan commented Aug 4, 2016

Previous ID SR-2278
Radar None
Original Reporter @belkadan
Type Task
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Task, CMake, SDKOverlay
Assignee None
Priority Medium

md5: 1cc4af2c3b7ed07de990b21e3b65c501

Issue Description:

The "overlay" libraries in stdlib/public/SDK/ need to be built in dependency graph order (e.g. Foundation's overlay must be built before AppKit's and so on). This order depends on the current header files in the system. I wrote a tool, utils/find-overlay-dependencies.sh, that uses clang -M to figure out which headers are included by a particular module, but the actual dependencies specified in the CMake files aren't validated in any way.

Since the process of looking for headers by module can be slow, I wouldn't expect it to be something to do on every reconfigure. However, if we could extract the list of dependencies used by CMake for the overlay targets, we could compare it to the dependencies found by the tool. A validation test would be a good way to ensure that these two do not get out of sync.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake SDKOverlay standard library Area: Standard library umbrella task
Projects
None yet
Development

No branches or pull requests

1 participant