Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-2855] Under -driver-show-incremental, if a build isn't incremental, say why #45449

Closed
belkadan opened this issue Oct 4, 2016 · 5 comments
Closed

[SR-2855] Under -driver-show-incremental, if a build isn't incremental, say why #45449

belkadan opened this issue Oct 4, 2016 · 5 comments
Assignees
@modocache
Labels
compiler The Swift compiler in itself good first issue Good for newcomers improvement legacy driver Area → compiler: the integrated C++ legacy driver. Succeeded by the swift-driver project

Comments

@belkadan
Copy link
Contributor

belkadan commented Oct 4, 2016

Previous ID SR-2855
Radar None
Original Reporter @belkadan
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, Driver, StarterBug
Assignee @modocache
Priority Medium

md5: 8b7347aeb4feb5bb680d5ea8406fc56a

Issue Description:

-driver-show-incremental is a debugging flag that prints out why the Swift driver thinks it needs to recompile a particular file. It's rather coarse-grained, but what it doesn't even attempt to do is state why a build that was expected to be incremental is in fact recompiling everything. We should make sure to print that out for all of the cases that result in silently rebuilding everything in Driver.cpp.

  • malformed build record file

  • new version of compiler

  • command-line options changed

  • file renamed or moved

  • (optionally) -embed-bitcode was passed

  • anything I missed?
@belkadan
Copy link
Contributor Author

belkadan commented Oct 4, 2016

*cough*@modocache*cough*

@modocache
Copy link
Mannequin

modocache mannequin commented Oct 5, 2016

Awesome! I'd love to try this one. (By the way, I'm stuck on https://bugs.swift.org/browse/SR-2660, in case you have advice there.)

@modocache
Copy link
Mannequin

modocache mannequin commented Oct 5, 2016

Perhaps a first step: #5128

@modocache
Copy link
Mannequin

modocache mannequin commented Oct 15, 2016

OK, starting to actually implement part of the list you included in the task description: #5308 Let me know what you think! 🙂

@modocache
Copy link
Mannequin

modocache mannequin commented Nov 16, 2016

OK, I submitted:

@belkadan, I think that should be enough to resolve this issue, right? Please re-open if not.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modocache modocache

Labels
compiler The Swift compiler in itself good first issue Good for newcomers improvement legacy driver Area → compiler: the integrated C++ legacy driver. Succeeded by the swift-driver project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@belkadan