Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-3455] Evaluation and Validation of Build Conditions Should Be Separate #46043

Closed
CodaFi opened this issue Dec 19, 2016 · 1 comment
Closed
Assignees
Labels
compiler The Swift compiler in itself good first issue Good for newcomers improvement parser Area → compiler: The legacy C++ parser

Comments

@CodaFi
Copy link
Member

CodaFi commented Dec 19, 2016

Previous ID SR-3455
Radar None
Original Reporter @CodaFi
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, Parser, StarterBug
Assignee @rintaro
Priority Medium

md5: d76a6968226878a35ed76eb3e8483ba5

relates to:

  • SR-3663 Successful '||' ignores rest of expression in conditional compilation directive

Issue Description:

Currently Parse handles both evaluation and validation of build configurations, but this can be flaky in practice. Especially because Parse wants to eat and report on the status of the whole condition, but evaluation wants to short circuit. ParseStmt should retain the validation portion of the function and Condition Resolver should absorb as much of the evaluation part as possible.

@rintaro
Copy link
Mannequin

rintaro mannequin commented May 19, 2017

#7955

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself good first issue Good for newcomers improvement parser Area → compiler: The legacy C++ parser
Projects
None yet
Development

No branches or pull requests

1 participant