Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-3496] Silent parameter shadowing is a source of subtle, hard to spot bugs #46084

Closed
swift-ci opened this issue Dec 27, 2016 · 0 comments
Closed
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-3496
Radar None
Original Reporter sv (JIRA User)
Type Bug
Status Resolved
Resolution Duplicate
Additional Detail from JIRA
Votes 0
Component/s
Labels Bug
Assignee None
Priority Medium

md5: 280c314c465f76f2372391a2e435806d

duplicates:

  • SR-1687 Swift does not warn about shadowing

relates to:

  • SR-8524 Shadowing in protocols leads to difficult to find bugs

Issue Description:

The problem is illustrated at http://stackoverflow.com/questions/39983561/swift-3-silently-allows-shadowing-a-parameter

This really, really leads to hard-to-spot bugs. Please reconsider, and add an appropriate warning to the compiler.

Sample code:

func f(_ x: inout Int?) {
var x: Int? // <– this declaration should produce a warning
x = 105
if x! < 1000 {}
}

var a: Int? = 3
f(&a)
print("(a)")

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Development

No branches or pull requests

1 participant