Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-385] Replace test/Interpreter/SDK/Inputs/libTestLoad.dylib with source code #43002

Open
gribozavr opened this issue Dec 26, 2015 · 3 comments
Open

[SR-385] Replace test/Interpreter/SDK/Inputs/libTestLoad.dylib with source code #43002

gribozavr opened this issue Dec 26, 2015 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers nfc Flag: No Functional Change

Comments

@gribozavr
Copy link
Collaborator

Previous ID SR-385
Radar None
Original Reporter @gribozavr
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: 8864d5e294a54457cd48f3fa6165e630

Issue Description:

Seems like we have a binary file checked into our tree – test/Interpreter/SDK/Inputs/libTestLoad.dylib. We should replace it with source code and update the test to first build the library.
@gribozavr
Copy link
Collaborator Author

/cc @belkadan

The commit that added this file was:

commit 14a2909cab25b6252c6c88dfa02233d37c9ba4e6
Author: Jordan Rose <jordan_rose@apple.com>
Date:   Fri Dec 19 17:33:03 2014 +0000

    Pass -L, -l, and -framework to REPL and interpret mode jobs.

    ...and then honor them.

    While here, make -l a little more flexible (see interpret_with_options test).

    rdar://problem/17830826, which unblocks the LLDB feature for the same.

    Swift SVN r24033

@belkadan
Copy link
Contributor

belkadan commented Jan 4, 2016

I think I was trying to avoid building dylibs in the non-validation tests, but now that we have interpreter mode on multiple platforms it's more important that we actually get good test coverage.

@Dante-Broggi
Copy link
Contributor

Has this been resolved? If so it should be closed.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added the nfc Flag: No Functional Change label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers nfc Flag: No Functional Change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@belkadan @gribozavr @AnthonyLatsis @Dante-Broggi