Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-4222] Improve the build script to guard against running on old versions of Swift #46805

Open
hartbit opened this issue Mar 11, 2017 · 4 comments
Open

[SR-4222] Improve the build script to guard against running on old versions of Swift #46805

hartbit opened this issue Mar 11, 2017 · 4 comments
Labels
build-script Area → utils: The build script improvement

Comments

@hartbit
Copy link
Collaborator

hartbit commented Mar 11, 2017

Previous ID SR-4222
Radar None
Original Reporter @hartbit
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Improvement, BuildScript
Assignee None
Priority Medium

md5: 7732e0bd069750c4ed0f91fad231ac96

Issue Description:

I don't know how easy this is to fix, but I was failing to get Swift to build for a while last night until I saw that my repo's origin was pointing to an old one-year old fork. `update-checkout` was cloning recent versions of the dependencies but was still stuck on my old swift repo.

Can something be done to warn of guard against this?
@belkadan
Copy link
Contributor

update-checkout is supposed to update the "swift" repo too. Was it not doing that?

@hartbit
Copy link
Collaborator Author

hartbit commented Mar 14, 2017

How does it do that? By pulling from origin? If that's the case it didn't work because my origin was pointing to my year-old fork. If it tries to do something smarter, it did not work.

@belkadan
Copy link
Contributor

Oh, I see what you mean. If the current branch doesn't have an upstream from Apple, it's not going to get the latest changes. Hm.

cc erg (JIRA User)

@hartbit
Copy link
Collaborator Author

hartbit commented Mar 14, 2017

In the end, it was ultimately my mistake. But it would have been great if the tool had warned me 🙂

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-script Area → utils: The build script improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hartbit @belkadan