Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-4235] Can't unedit a package that's no longer in dependency graph #5070

Closed
rballard opened this issue Mar 13, 2017 · 2 comments
Closed
Labels

Comments

@rballard
Copy link
Contributor

Previous ID SR-4235
Radar rdar://problem/31022816
Original Reporter @rballard
Type Bug
Status Closed
Resolution Duplicate
Environment

Apple Swift Package Manager - Swift 3.1.0 (swiftpm-12084)

Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 77c9e37148c50bdf48a44dd7b7e82259

duplicates:

  • SR-3689 Persist editable state even when an editable package is no longer required

Issue Description:

If you edit a package that's in your dependency graph, then change another dependency (by pinning it to a different revision, or by editing it and changing what's checked out), such that the first dependency is no longer in your dependency graph, you now can't unedit the first dependency. SwiftPM gives an "error: The provided package was not found"

I'd expect you to be able to unedit it, though you then couldn't re-edit it as long as it wasn't in the dependency graph.

Steps to reproduce:

  1. Check out vapor (git@github.com:vapor/vapor.git)
  2. Check out the 2.0.0-alpha.7 tag
  3. Run `swift package show-dependencies` to load the dependency graph
  4. Run `swift package edit CTLS --branch test`
  5. Run `swift package edit TLS --branch test`
  6. Run `cd Packages/TLS && git checkout 2.0.0-alpha.2 && cd ../..`
  7. Run `swift package unedit CTLS`
@rballard
Copy link
Contributor Author

@swift-ci create

@rballard
Copy link
Contributor Author

Ah, we already have SR-3689 for this.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant