Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-4302] Re-enable swift calling convention on Windows when mangling crasher is fixed #46885

Closed
swift-ci opened this issue Mar 21, 2017 · 4 comments
Closed

[SR-4302] Re-enable swift calling convention on Windows when mangling crasher is fixed #46885

swift-ci opened this issue Mar 21, 2017 · 4 comments
Assignees
@compnerd
Labels
affects ABI Flag: Affects ABI bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself swift 4.0 Windows Platform: Windows

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-4302
Radar rdar://problem/31408034
Original Reporter hughbe (JIRA User)
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, AffectsABI, Swift4, Windows
Assignee @compnerd
Priority Medium

md5: b6ea6a1ceaa3bd618d4171ce43a55a15

is duplicated by:

  • SR-4303 Re-enable swift calling convention on Windows when mangling crasher is fixed

Issue Description:

http://bugs.llvm.org/show_bug.cgi?id=32000
#8237
@swift-ci
Copy link
Collaborator Author

Comment by Hugh Bellamy (JIRA)

Opened https://reviews.llvm.org/D31372 to support mangling the Swift calling convention on Windows.

God knows if I've done it right, haven't been able to figure out how to insert a `git diff` in Phabricator

@bob-wilson
Copy link

@swift-ci create

@compnerd
Copy link
Collaborator

compnerd commented Feb 3, 2018

https://reviews.llvm.org/D42768 has a much more complete fix.

@compnerd
Copy link
Collaborator

compnerd commented Feb 4, 2018

SwiftCC has been forced for a while now. The clang side of the issue still exists, and a separate issue tracks the work to support mangling swift CC.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compnerd compnerd

Labels
affects ABI Flag: Affects ABI bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself swift 4.0 Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@compnerd @swift-ci @bob-wilson