Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-4354] New String design #46933

Closed
bob-wilson opened this issue Mar 25, 2017 · 3 comments
Closed

[SR-4354] New String design #46933

bob-wilson opened this issue Mar 25, 2017 · 3 comments
Assignees
@airspeedswift
Labels
affects ABI Flag: Affects ABI improvement standard library Area: Standard library umbrella

Comments

@bob-wilson
Copy link

Previous ID SR-4354
Radar rdar://problem/20486780
Original Reporter @bob-wilson
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Improvement, AffectsABI
Assignee @airspeedswift
Priority Medium

md5: 22ab97c83270399b4f65d192960b83b9

relates to:

  • SR-2081 String views should have ASCII optimizations

Issue Description:

We are working to revise the design of String for Swift 4. This includes a variety of changes, including:

https://bugs.swift.org/browse/SR-4003 Optimize the representation of String
https://bugs.swift.org/browse/SR-4004 Create a shim to ICU
https://bugs.swift.org/browse/SR-4006 Enable String to store Latin1 characters with 8-bit encoding
https://bugs.swift.org/browse/SR-4007 Implement Small String optimization

I am filing this issue to track the overall effort for the purpose of ABI stability.
@bob-wilson
Copy link
Author

At this point all of the String changes relevant to the ABI are done in Swift 4.2.

@bob-wilson
Copy link
Author

I should clarify that: there may still be further changes that affect String but no more so than for other standard library types. The big changes for the 2-word implementation and the small string optimization are done.

@milseman
Copy link
Mannequin

milseman mannequin commented Apr 22, 2019

Done in Swift 5

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@airspeedswift airspeedswift

Labels
affects ABI Flag: Affects ABI improvement standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bob-wilson