Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-4780] Can not run performance tests that are not in precommit suite #47357

Closed
palimondo mannequin opened this issue May 2, 2017 · 2 comments
Closed

[SR-4780] Can not run performance tests that are not in precommit suite #47357

palimondo mannequin opened this issue May 2, 2017 · 2 comments
Assignees
@palimondo
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. performance

Comments

@palimondo
Copy link
Mannequin

palimondo mannequin commented May 2, 2017

Previous ID SR-4780
Radar None
Original Reporter @palimondo
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Bug, Performance
Assignee @palimondo
Priority Medium

md5: 5de7172a16e6578e683b0125bbccb7f8

Issue Description:

When running performance tests with Benchmark_Driver or with Benchmark_O and co., when specifying tests outside of the default precommit test suite, no tests are executed.

$ Benchmark_Driver run Fibonacci
$ Benchmark_O Fibonacci
#,TEST,SAMPLES,MIN(us),MAX(us),MEAN(us),SD(us),MEDIAN(us)

Totals,0,0,0,0,0,0

This is due to bug in DriverUtils.swift concerning the interaction between the only-precommit and filters arguments to findTestsToRun method.

The workaround, but only for Benchmark_O and co. is to specify – run-all option.
@palimondo
Copy link
Mannequin Author

palimondo mannequin commented May 7, 2017

#9310

@palimondo
Copy link
Mannequin Author

palimondo mannequin commented Jun 12, 2017

Fixed.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palimondo palimondo

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants