Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5058] Redundant Conformance Diagnostic should have an associated fixit #47634

Open
CodaFi opened this issue May 31, 2017 · 3 comments
Open

[SR-5058] Redundant Conformance Diagnostic should have an associated fixit #47634

CodaFi opened this issue May 31, 2017 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation good first issue Good for newcomers

Comments

@CodaFi
Copy link
Member

CodaFi commented May 31, 2017

Previous ID SR-5058
Radar rdar://32431756
Original Reporter @CodaFi
Type Bug
Status In Progress
Resolution

Attachment: Download

Additional Detail from JIRA
Votes 1
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee interfere (JIRA)
Priority Medium

md5: 5985872320450fd433971928ef7a5b14

Issue Description:

The redundant conformance diagnostic can point at the protocol that is redundant, but doesn’t actually offer to remove it.

protocol Foo {}
struct Bar {}

extension Bar: Foo {}
extension Bar: Foo {} // redundant conformance of 'Bar' to protocol 'Foo'
@alexito4
Copy link

I was about to open a ticket for the same warning. I would just to point out this specific instance, which different from the one in the description:

I imagine that here the fix it should remove the "where" clause, but keeping the non redundant restrictions (if any). Not sure how feasible is that.

@belkadan
Copy link
Contributor

Resetting assignee for all Starter Bugs not modified since 2018.

@swift-ci
Copy link
Collaborator

Comment by Alexey Komnin (JIRA)

I'd like to try to fix this.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@belkadan @alexito4 @CodaFi @swift-ci