Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-513] Add file name for dumped files in AST #43130

Closed
swift-ci opened this issue Jan 10, 2016 · 2 comments
Closed

[SR-513] Add file name for dumped files in AST #43130

swift-ci opened this issue Jan 10, 2016 · 2 comments
Labels
compiler The Swift compiler in itself improvement

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-513
Radar None
Original Reporter vipul (JIRA User)
Type Improvement
Status Resolved
Resolution Duplicate

Attachment: Download

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement
Assignee vipul (JIRA)
Priority Medium

md5: 543b306241ca5f41f6748df4b39bfa25

duplicates:

  • SR-7904 AST dump - can't distinguish files

Issue Description:

I've been looking through the code and getting familiar (first time aspiring contributor!), and I saw a FIXME in ASTDumper.cpp for dumping filenames along with the "file" tag. We should have filenames instead of just a $(file) placeholder. Upon the ASTDumper seeing that the DeclContext is of type FileUnit, the FileUnitKind can be identified and the name can be extracted.
@Dante-Broggi
Copy link
Contributor

Is this resolved, or no longer valid? If either, this should be closed.

@belkadan
Copy link
Contributor

belkadan commented Nov 9, 2018

Oops, looks like this happened in SR-7904!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler The Swift compiler in itself improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@belkadan @swift-ci @Dante-Broggi