Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5650] Remove parent field from type metadata #48220

Closed
slavapestov opened this issue Aug 8, 2017 · 6 comments
Closed

[SR-5650] Remove parent field from type metadata #48220

slavapestov opened this issue Aug 8, 2017 · 6 comments
Assignees
@slavapestov
Labels
improvement

Comments

@slavapestov
Copy link
Member

Previous ID SR-5650
Radar rdar://problem/33767511
Original Reporter @slavapestov
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s
Labels Improvement
Assignee @slavapestov
Priority Medium

md5: ca14a8c7da973b5a48643d473262fe65

is duplicated by:

  • SR-4323 Deadlock instantiating class which subclasses with explicit type scoped inside subclass
  • SR-4611 Runtime crash with nested type used as superclass generic argument
  • SR-5086 Cyclic metadata dependency error in generic type with nested enum with associated value of outer generic type
  • SR-5432 Using nested type as a superclass generic parameter leads to a crash
  • SR-5711 EXC_BAD_INSTRUCTION crash when using inner type as generics parameter
  • SR-6376 Nested enum crashes at runtime without "indirect"
  • SR-6551 Crash in type metadata accessor with generic class
  • SR-6686 Runtime crash when specifying inner type for generic parameter in superclass

Issue Description:

Instead, type metadata should store generic arguments from all parent contexts.

This will make it easier to support generic types nested inside generic functions, or generic types nested inside constrained extensions that add protocol conformances.
@slavapestov
Copy link
Member Author

@swift-ci create

@slavapestov
Copy link
Member Author

#12052

@NachoSoto
Copy link
Contributor

Did this ship with a Swift version already?

@slavapestov
Copy link
Member Author

No

@NachoSoto
Copy link
Contributor

This is still crashing at runtime on Swift 4.0.2.

@NachoSoto
Copy link
Contributor

Confirmed fixed on Swift 4.1.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavapestov slavapestov

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slavapestov @NachoSoto