Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-5995] update-checkout --tags should fetch --tags before attempting to find a tag #48552

Closed
gottesmm opened this issue Sep 26, 2017 · 8 comments
Labels
good first issue Good for newcomers improvement update-checkout Area → utils: the `update-checkout` script

Comments

@gottesmm
Copy link
Member

Previous ID SR-5995
Radar None
Original Reporter @gottesmm
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Source Tooling
Labels Improvement, StarterBug, UpdateCheckout
Assignee None
Priority Medium

md5: c6e5dad28c589021a0d47511833f3c96

is duplicated by:

  • SR-7356 update-checkout --tag should fetch tags first

Issue Description:

I recently was trying to reproduce a report of a filed build of a tag. Sadly I had not run fetch --tags for a while, so update-checkout --tags failed. When you have a long running repository this can happen easily since fetch normally doesn't grab --tags.

@swift-ci
Copy link
Collaborator

swift-ci commented Oct 6, 2017

Comment by Rahul Ranjan (JIRA)

Hi @gottesmm , can give me more context, I will take this up.

@gottesmm
Copy link
Member Author

gottesmm commented Oct 7, 2017

The issue is that git fetch does not fetch tags as well. You have to pass an additional --tags flag, e.g.: git fetch --tags. I think the right thing to do here is just to change git fetch to use git fetch --tags. The --tags is additional according to the git man page.

@swift-ci
Copy link
Collaborator

Comment by Rahul Ranjan (JIRA)

I checked out `update_checkout.py` but haven't found any place where we are fetching remote tags.Also, we can't run

$update-checkout --tags  # There is --tag argument but it is just from checking single tag

as tags is not a correct argument flag. I guess if we want to fetch all the remote tags then we will need to implement a new argument may be --tags and methods for it.

Right now there is a `tag` flag which fetches a particular tag and updates it and it works fine.

$ update-checkout --tag refs/tags/swift-DEVELOPMENT-SNAPSHOT-2017-09-23-a

@gottesmm I am just clarifying the requirement with the existing scenario. Let me know if you want me to add a method to fetch all tags.

@gottesmm
Copy link
Member Author

That isn't what I meant. I meant I think we just should always be passing --tags to git in update_checkout. Then we will always fetch tags in addition to the rest of the normal things we fetch.

@swift-ci
Copy link
Collaborator

Comment by Rahul Ranjan (JIRA)

@gottesmm Thanks for the clarification. I have created the pull request #12455

@Moximillian
Copy link
Contributor

Is this fixed already? The PR is merged, but not closed. Also this bug is still open.

@gottesmm
Copy link
Member Author

gottesmm commented Apr 8, 2018

Yes. This is complete. Lets resolve this![]( Thanks @Moximillian)

@gottesmm
Copy link
Member Author

gottesmm commented Apr 8, 2018

3458d45

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

No branches or pull requests

3 participants