Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-6178] -fblocks should be allowed in .pc files or enabled by default #4935

Closed
kevints mannequin opened this issue Oct 18, 2017 · 3 comments
Closed

[SR-6178] -fblocks should be allowed in .pc files or enabled by default #4935

kevints mannequin opened this issue Oct 18, 2017 · 3 comments
Labels
bug

Comments

@kevints
Copy link
Mannequin

kevints mannequin commented Oct 18, 2017

Previous ID SR-6178
Radar rdar://problem/28109524
Original Reporter @kevints
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: b25ebe3b007bd9463ab4c38d8da0bb28

Issue Description:

On Linux I have a C library that defines API with callbacks as blocks. We attempted to add -fblocks to Cflags in a .pc file but got this error:

warning: error while trying to use pkgConfig flags for swift-system-libdispatch: nonWhitelistedFlags("Non whitelisted flags found: [\"-fblocks\"] in pc file libdispatch")

The end result is that every user of this library needs to add {-Xcc -fblocks} to their swift build command-line. This should either be allowed in .pc files or enabled by default.
@belkadan
Copy link

@aciidb0mb3r, you just fixed this, right? (by turning on -fblocks for all C files)

@aciidgh
Copy link
Member

aciidgh commented Oct 20, 2017

Not yet

@aciidgh
Copy link
Member

aciidgh commented Oct 21, 2017

#1370

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@belkadan @aciidgh