Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-65] build-script generates CMAKEGENERATE without quotes #42687

Closed
swift-ci opened this issue Dec 5, 2015 · 3 comments
Closed

[SR-65] build-script generates CMAKEGENERATE without quotes #42687

swift-ci opened this issue Dec 5, 2015 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build-script Area → utils: The build script compiler The Swift compiler in itself

Comments

@swift-ci
Copy link
Collaborator

swift-ci commented Dec 5, 2015

Previous ID SR-65
Radar None
Original Reporter liangz (JIRA User)
Type Bug
Status Closed
Resolution Done
Environment

Macbook Air with OS X Ei Capitan

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, BuildScript
Assignee None
Priority Medium

md5: da5a5c9c9d5a1fb51b76d97c9f088459

Issue Description:

I am using Macbook Air with OS X EI Capitan, and I am building swift (commit number c959ce2) with the following command.
./build-script --debug-swift --make --build-subdir ../../build

The error is "CMake Error: Could not create named generator Unix".
Then, I copy the generated command and insert quotes for Unix Makefiles.
It builds correctly. I think there are something missing in the build-script for adding the quotes.
@swift-ci
Copy link
Collaborator Author

swift-ci commented Dec 5, 2015

Comment by Liang Zou (JIRA)

More information of the generated command:

... ...
// building for cmark and llvm successfully.
... ...
swift: using standard linker

  • cd /Users/liang/codes/swifts/build/../../build/swift-macosx-x86_64
  • /opt/local/bin/cmake -G Unix Makefiles -DCMAKE_C_COMPILER:PATH=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -DCMAKE_CXX_COMPILER:PATH=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -DCMAKE_C_FLAGS= -DCMAKE_CXX_FLAGS= -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DSWIFT_STDLIB_BUILD_TYPE:STRING=Debug -DSWIFT_STDLIB_ASSERTIONS:BOOL=TRUE -DSWIFT_NATIVE_LLVM_TOOLS_PATH:STRING= -DSWIFT_NATIVE_CLANG_TOOLS_PATH:STRING= -DSWIFT_NATIVE_SWIFT_TOOLS_PATH:STRING= -DSWIFT_BUILD_TOOLS:BOOL=TRUE -DSWIFT_BUILD_STDLIB:BOOL=TRUE -DSWIFT_BUILD_SDK_OVERLAY:BOOL=TRUE -DSWIFT_BUILD_STATIC_STDLIB:BOOL=FALSE -DSWIFT_BUILD_EXAMPLES:BOOL=TRUE -DSWIFT_INCLUDE_TESTS:BOOL=TRUE -DSWIFT_INSTALL_COMPONENTS:STRING= -DSWIFT_EMBED_BITCODE_SECTION:BOOL=FALSE -DSWIFT_DARWIN_DEPLOYMENT_VERSION_OSX=10.9 -DSWIFT_DARWIN_DEPLOYMENT_VERSION_IOS=7.0 -DSWIFT_DARWIN_DEPLOYMENT_VERSION_TVOS=9.0 -DSWIFT_DARWIN_DEPLOYMENT_VERSION_WATCHOS=2.0 -DSWIFT_AST_VERIFIER:BOOL=TRUE -DSWIFT_VERIFY_ALL:BOOL=FALSE -DSWIFT_RUNTIME_ENABLE_DTRACE:BOOL=FALSE -DSWIFT_RUNTIME_ENABLE_LEAK_CHECKER:BOOL=FALSE -DSWIFT_ENABLE_TARGET_LINUX:BOOL=TRUE -DCMAKE_INSTALL_PREFIX:PATH=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr -DLLVM_CONFIG:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64/bin/llvm-config -DCMARK_PATH_TO_CLANG_SOURCE:PATH=/Users/liang/codes/swifts/llvm/tools/clang -DCMARK_PATH_TO_CLANG_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64 -DCMARK_PATH_TO_LLVM_SOURCE:PATH=/Users/liang/codes/swifts/llvm -DCMARK_PATH_TO_LLVM_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64 -DCMARK_PATH_TO_CMARK_SOURCE:PATH=/Users/liang/codes/swifts/cmark -DCMARK_PATH_TO_CMARK_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/cmark-macosx-x86_64 -DCMARK_CMARK_LIBRARY_DIR:PATH=/Users/liang/codes/swifts/build/../../build/cmark-macosx-x86_64/src/Debug -DCMAKE_INSTALL_PREFIX:PATH=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr -DLLVM_CONFIG:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64/bin/llvm-config -DLLVM_PATH_TO_CLANG_SOURCE:PATH=/Users/liang/codes/swifts/llvm/tools/clang -DLLVM_PATH_TO_CLANG_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64 -DLLVM_PATH_TO_LLVM_SOURCE:PATH=/Users/liang/codes/swifts/llvm -DLLVM_PATH_TO_LLVM_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64 -DLLVM_PATH_TO_CMARK_SOURCE:PATH=/Users/liang/codes/swifts/cmark -DLLVM_PATH_TO_CMARK_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/cmark-macosx-x86_64 -DLLVM_CMARK_LIBRARY_DIR:PATH=/Users/liang/codes/swifts/build/../../build/cmark-macosx-x86_64/src/Debug -DCMAKE_INSTALL_PREFIX:PATH=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr -DLLVM_CONFIG:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64/bin/llvm-config -DSWIFT_PATH_TO_CLANG_SOURCE:PATH=/Users/liang/codes/swifts/llvm/tools/clang -DSWIFT_PATH_TO_CLANG_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64 -DSWIFT_PATH_TO_LLVM_SOURCE:PATH=/Users/liang/codes/swifts/llvm -DSWIFT_PATH_TO_LLVM_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/llvm-macosx-x86_64 -DSWIFT_PATH_TO_CMARK_SOURCE:PATH=/Users/liang/codes/swifts/cmark -DSWIFT_PATH_TO_CMARK_BUILD:PATH=/Users/liang/codes/swifts/build/../../build/cmark-macosx-x86_64 -DSWIFT_CMARK_LIBRARY_DIR:PATH=/Users/liang/codes/swifts/build/../../build/cmark-macosx-x86_64/src/Debug /Users/liang/codes/swifts/swift
    CMake Error: Could not create named generator Unix

@gribozavr
Copy link
Collaborator

Could you try again, now that #184 has landed?

@swift-ci
Copy link
Collaborator Author

swift-ci commented Dec 6, 2015

Comment by Liang Zou (JIRA)

Yeah, thanks. that solved the problem.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build-script Area → utils: The build script compiler The Swift compiler in itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gribozavr @swift-ci