Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-6827] [StringGuts] String switch enum cache regressions. #49376

Open
milseman mannequin opened this issue Jan 24, 2018 · 2 comments
Open

[SR-6827] [StringGuts] String switch enum cache regressions. #49376

milseman mannequin opened this issue Jan 24, 2018 · 2 comments
Assignees
@milseman
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella

Comments

@milseman
Copy link
Mannequin

milseman mannequin commented Jan 24, 2018

Previous ID SR-6827
Radar rdar://problem/36825366
Original Reporter @milseman
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug
Assignee @milseman
Priority Medium

md5: c39b12d25b13a57bd396b3945c6ab5cf

Issue Description:

Regression from #14046

The string enum cache code has some ARC going on and more regressions here. I’ve seen poor loop-invariant hoisting and control flow de-duplication, such as with Calculator benchmark. I wasn’t able to figure out root cause though.

Affects StringEnumRawValueInitialization
@milseman
Copy link
Mannequin Author

milseman mannequin commented Jan 24, 2018

+CC @eeckstein. I didn't pour into this one too much, but we probably can traffic in more appropriate types than StaticString now.

@milseman
Copy link
Mannequin Author

milseman mannequin commented Jan 24, 2018

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milseman milseman

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants