Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6950] TextOutputStreamable doesn't play well with Substring #49498

Open
lilyball mannequin opened this issue Feb 7, 2018 · 0 comments
Open

[SR-6950] TextOutputStreamable doesn't play well with Substring #49498

lilyball mannequin opened this issue Feb 7, 2018 · 0 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella

Comments

@lilyball
Copy link
Mannequin

lilyball mannequin commented Feb 7, 2018

Previous ID SR-6950
Radar None
Original Reporter @lilyball
Type Bug
Environment

Apple Swift version 4.0.3 (swiftlang-900.0.74.1 clang-900.0.39.2)
Target: x86_64-apple-macosx10.9

Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug
Assignee None
Priority Medium

md5: b353b5c59fccd6a8cb6bfe95409fd252

Issue Description:

TextOutputStream.write(_:) takes a String as input. This means that the TextOutputStreamable implementation on Substring ends up copying the string, even though the whole point of the protocol is to avoid unnecessary string copies.

In the short term Substring should remove its implementation of TextOutputStreamable so as to not be misleading. In the longer term we should have a solution that allows streaming substrings, because this same issue will affect any type that uses substrings internally and still wants to be streamable.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella
Projects
None yet
Development

No branches or pull requests

0 participants