Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-7100] Change default ownership for passing parameters to use the "guaranteed" convention #49648

Closed
eeckstein opened this issue Mar 1, 2018 · 9 comments
Assignees
Labels
affects ABI Flag: Affects ABI compiler The Swift compiler in itself feature A feature request or implementation ownership Feature: Ownership modifiers and semantics SIL SILGen Area → compiler: The SIL generation stage task

Comments

@eeckstein
Copy link
Member

Previous ID SR-7100
Radar rdar://problem/34120147
Original Reporter @eeckstein
Type New Feature
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels New Feature
Assignee @gottesmm
Priority Medium

md5: 161a7e413f6f94d7eea269d013807334

relates to:

  • SR-4355 Update standard library to use memory ownership features

Issue Description:

For details see: https://forums.swift.org/t/proposal-to-change-the-default-ownership-for-passing-parameters/10261

@gottesmm
Copy link
Member

gottesmm commented Mar 9, 2018

I am starting to "thin" the branch out by upstreaming things. I am going to turn on +0 with a small commit so I can revert. This is going to cause me to need to upstream all the test updates/etc before that. The hope is to merge the final version of this after the stable-merge happens tomorrow.

@gottesmm
Copy link
Member

Branch thinning is continuing from ~30 patches to ~20.

@gottesmm
Copy link
Member

Down to ~5.

@gottesmm
Copy link
Member

Just to update this real quick:

1. On the bots I got my first srouce compatibility success run.
2. There was some confusion around how I was going to upstream this. I am no longer doing the nice way that would let us revert. It was taking me too long to get the tooling correct (I kept on running into problems caused by moving tests). I am now just going the old traditional way of change the world.

@gottesmm
Copy link
Member

Another update. The benchmarks all pass except for floating point tests that are also failing on master without +0. Making progress.

@gottesmm
Copy link
Member

Floating point tests fixed on master. Reran benchmarks everything works. Fixing the last couple of failing tests and then we should have a completely green PR in a bit.

@gottesmm
Copy link
Member

Finally got this through the CI in: 54b38d4

@bob-wilson
Copy link

Sounds like this is done then. Congrats, Michael!

@gottesmm
Copy link
Member

Yes it is complete!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added task feature A feature request or implementation SILGen Area → compiler: The SIL generation stage SIL affects ABI Flag: Affects ABI ownership Feature: Ownership modifiers and semantics and removed new feature labels Jan 31, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects ABI Flag: Affects ABI compiler The Swift compiler in itself feature A feature request or implementation ownership Feature: Ownership modifiers and semantics SIL SILGen Area → compiler: The SIL generation stage task
Projects
None yet
Development

No branches or pull requests

4 participants