Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-7273] Sourcery source breakage: dependency on SourceKitten that uses IUOs in ways that are disallowed #49821

Closed
rudkx opened this issue Mar 25, 2018 · 7 comments
Closed

[SR-7273] Sourcery source breakage: dependency on SourceKitten that uses IUOs in ways that are disallowed #49821

rudkx opened this issue Mar 25, 2018 · 7 comments
Assignees
@clackary
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. source compatibility

Comments

@rudkx
Copy link
Member

rudkx commented Mar 25, 2018

Previous ID SR-7273
Radar rdar://problem/40863363
Original Reporter @rudkx
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s
Labels Bug, SourceCompatibility
Assignee @clackary
Priority Medium

md5: 42f49e57e511d788686a065aad2a4d69

relates to:

  • SR-6556 Sourcery source breakage: error: ambiguous use of 'trackDifference(actual:expected:)'

Issue Description:

It looks like we currently have Sourcery XFAILed for master, which is apparently hiding this issue on master. On swift-4.2-branch, though, it is not yet XFAILed and as a result we are hitting issues like:

/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite/project_cache/Sourcery/.build/checkouts/SourceKitten.git-6484296299232452758/Source/SourceKittenFramework/Request.swift:226:96: error: value of optional type 'sourcekitd_uid_t?' (aka 'Optional<OpaquePointer>') not unwrapped; did you mean to use '!' or '?'?
                    sourcekitd_uid_get_from_cstr("key.request"): sourcekitd_request_uid_create(sourcekitd_uid_get_from_cstr("source.request.editor.open")),

The underlying issue in SourceKitten was fixed (it had uses of IUOs that were disallowed by SE-0054 but not enforced until recently.
@rudkx
Copy link
Member Author

rudkx commented Mar 25, 2018

As a side note, it's not at all clear to me why we still have this XFAILed for master since it seems like the issue from SR-6556 was resolved.

@belkadan
Copy link
Contributor

najacque (JIRA User), who's in charge of Source Compat suite maintenance now?

@swift-ci
Copy link
Collaborator

Comment by Nicole Jacque (JIRA)

That would be @clackary

@clackary
Copy link
Contributor

I removed the old XFAIL from master, and ran this locally. I can verify that they are the same failures as with 4.2...

./Sourcery/.build/checkouts/SourceKitten.git--9034366123564885496/Source/SourceKittenFramework/Request.swift:305:92: error: value of optional type 'sourcekitd_uid_t?' (aka 'Optional<OpaquePointer>') not unwrapped; did you mean to use '!' or '?'?
               sourcekitd_uid_get_from_cstr("key.request"): sourcekitd_request_uid_create(sourcekitd_uid_get_from_cstr("source.request.editor.replacetext")),                                                                                                                                                       ./Sourcery/.build/checkouts/SourceKitten.git--9034366123564885496/Source/SourceKittenFramework/Request.swift:314:92: error: value of optional type 'sourcekitd_uid_t?' (aka 'Optional<OpaquePointer>') not unwrapped; did you mean to use '!' or '?'?
               sourcekitd_uid_get_from_cstr("key.request"): sourcekitd_request_uid_create(sourcekitd_uid_get_from_cstr("source.request.docinfo")),

Sounds like we're going to need an updated 4.0 hash from Sourcery. I'll reach out to the maintainer to request an update.

@clackary
Copy link
Contributor

Sent email to Sourcery project maintainer, requesting an updated 4.0 hash.

@swift-ci
Copy link
Collaborator

swift-ci commented Jun 6, 2018

Comment by Nicole Jacque (JIRA)

@swift-ci create

@clackary
Copy link
Contributor

This has been resolved as of https://github.com/apple/swift-source-compat-suite/pull/184

Looks like the update has also uncovered a new issue. Will file a new bug for this.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clackary clackary

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. source compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rudkx @belkadan @clackary @swift-ci