Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-7482] [Small String] NSStringConversion regression #50025

Closed
milseman mannequin opened this issue Apr 19, 2018 · 2 comments
Closed

[SR-7482] [Small String] NSStringConversion regression #50025

milseman mannequin opened this issue Apr 19, 2018 · 2 comments
Assignees
@Catfish-Man @milseman
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. performance standard library Area: Standard library umbrella

Comments

@milseman
Copy link
Mannequin

milseman mannequin commented Apr 19, 2018

Previous ID SR-7482
Radar rdar://problem/39578066
Original Reporter @milseman
Type Bug
Status Reopened
Resolution
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug, Performance
Assignee @milseman
Priority Medium

md5: a3429e2bd7abbc6f6879ca42134c2c27

Issue Description:

Due to aggressive attempts at forming small strings, NSStringConversion benchmark has regressed while trying to unpack tagged NSStrings. There may be some general tweaking and tuning to help, and ideally we'd reduce the overhead associated with CFStringGetBytes through a more direct access.

#14755
@milseman
Copy link
Mannequin Author

milseman mannequin commented Apr 19, 2018

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@Catfish-Man
Copy link
Member

This was fixed in a bunch of pieces, but after #59823 it looks like we're ahead of where we were

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Catfish-Man Catfish-Man

@milseman milseman

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. performance standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Catfish-Man