Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-7714] test/lit.cfg should complain if you use it with an Xcode build directory but don't set build_mode #50254

Open
belkadan opened this issue May 17, 2018 · 0 comments
Labels
compiler The Swift compiler in itself improvement

Comments

@belkadan
Copy link
Contributor

Previous ID SR-7714
Radar None
Original Reporter @belkadan
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement
Assignee None
Priority Medium

md5: 5df859928a412f669191e0c1abba03ae

Issue Description:

When running lit tests from the command line in an Xcode build directory, you have to provide the build_mode parameter in order for our lit.cfg to find the correct built binaries (see comments on SR-7562). lit.cfg itself should be able to detect if it's being run from an Xcode-based build directory and complain if build_mode isn't set.

I'm not exactly sure of the best way to do this (possibly another expansion in lit.site.cfg.in based on the CMake generator?) but it would be a nice usability improvement.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself improvement
Projects
None yet
Development

No branches or pull requests

1 participant