Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-807] Implement support for SE-0035 Limiting inout capture to @noescape contexts #43419

Closed
lattner mannequin opened this issue Feb 24, 2016 · 5 comments
Closed

[SR-807] Implement support for SE-0035 Limiting inout capture to @noescape contexts #43419

lattner mannequin opened this issue Feb 24, 2016 · 5 comments
Assignees
@dduan
Labels
compiler The Swift compiler in itself improvement

Comments

@lattner
Copy link
Mannequin

lattner mannequin commented Feb 24, 2016

Previous ID SR-807
Radar None
Original Reporter @lattner
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 1
Component/s Compiler
Labels Improvement
Assignee @dduan
Priority Medium

md5: 2b5e8f23c2f4e02c9da0531a0a482008

Issue Description:

SE-0035 has been accepted, we need to implement it:

1. Implement the new semantic restriction and diagnostic.
2. Eliminate the SILGen support for this (producing the inout shadow)
3. Eliminate the inoutdeshadowing SIL pass.
@lattner
Copy link
Mannequin Author

lattner mannequin commented Jun 4, 2016

@dduan, is this complete?

@ematejska
Copy link
Mannequin

ematejska mannequin commented Jul 7, 2016

This is done no?
#2354

@dduan
Copy link
Collaborator

dduan commented Jul 7, 2016

@ematejska Only step one as Chris outlined in the description is done.

@lattner
Copy link
Mannequin Author

lattner mannequin commented Jul 7, 2016

I think it is fair to say that the user-facing aspect of this work is done. The rest of it can be split out to another SR, since it is effectively an internal cleanup for the compiler at this point.

@dduan
Copy link
Collaborator

dduan commented Oct 30, 2016

resolved here: #5218

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dduan dduan

Labels
compiler The Swift compiler in itself improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dduan