Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-821] Implement SE-0038: Package Manager C Language Target Support #5314

Closed
rballard opened this issue Feb 26, 2016 · 10 comments
Closed

[SR-821] Implement SE-0038: Package Manager C Language Target Support #5314

rballard opened this issue Feb 26, 2016 · 10 comments

Comments

@rballard
Copy link
Contributor

Previous ID SR-821
Radar rdar://problem/30018985
Original Reporter @rballard
Type New Feature
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels New Feature
Assignee xpl0re (JIRA)
Priority Medium

md5: a6425fbc57ea02e8b07460cffe6cd25b

Issue Description:

Implement the Package Manager C Language Target Support proposal:

https://github.com/apple/swift-evolution/blob/master/proposals/0038-swiftpm-c-language-targets.md

@ddunbar
Copy link
Member

ddunbar commented May 20, 2016

@aciidb0mb3r do you know what is left here? I know we still are missing support for Obj-C/C++ source suffixes, I'm not exactly sure what else there is. We also should ensure we have test coverage for everything we support.

@ankitspd
Copy link
Member

except obj-c/c++ everything in proposal is implemented and I think we have pretty good test coverage for C modules features we support (eg iquote, modulemap generation etc)
can you elaborate a bit on how objc/c++ is supposed to work? is it allowed to have mixture of c/objc/c++ code? do we need to use clang++ instead if language is cpp?

@ddunbar
Copy link
Member

ddunbar commented May 20, 2016

No, no mixed targets, we just need to recognize the full set of source suffixes. To start with, I am fine with using Clang's default arguments for each language, and we don't need to use `clang++` anywhere.

@ddunbar
Copy link
Member

ddunbar commented May 20, 2016

We should recognize these suffixes (case folded):

Objective-C: ["m"]
Objective-C++: ["mm"]
C++: ["cc", "cpp", "cxx"]

and for headers we should also recognize:

C++: ["hpp", "inc"]

@ddunbar
Copy link
Member

ddunbar commented May 20, 2016

Historically some system would treat uppercase suffixes as C++, but I don't think that is a behavior we should replicate since it is hard to ensure reliable cross platform behavior. Any users of such conventions will have to migrate.

@ankitspd
Copy link
Member

@ddunbar Do you think anything else is pending or can this be marked resolved now?

@ddunbar
Copy link
Member

ddunbar commented Aug 15, 2016

This is done.

@swift-ci
Copy link
Contributor

Comment by Myke Olson (JIRA)

@swift-ci create

1 similar comment
@swift-ci
Copy link
Contributor

Comment by Myke Olson (JIRA)

@swift-ci create

@swift-ci
Copy link
Contributor

Comment by Myke Olson (JIRA)

Need to sync to radar and I can't modify the radar URL field when it's closed. Will close again in a minute.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants