New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-821] Implement SE-0038: Package Manager C Language Target Support #5314
Comments
@aciidb0mb3r do you know what is left here? I know we still are missing support for Obj-C/C++ source suffixes, I'm not exactly sure what else there is. We also should ensure we have test coverage for everything we support. |
except obj-c/c++ everything in proposal is implemented and I think we have pretty good test coverage for C modules features we support (eg iquote, modulemap generation etc) |
No, no mixed targets, we just need to recognize the full set of source suffixes. To start with, I am fine with using Clang's default arguments for each language, and we don't need to use `clang++` anywhere. |
We should recognize these suffixes (case folded): Objective-C: ["m"] and for headers we should also recognize: C++: ["hpp", "inc"] |
Historically some system would treat uppercase suffixes as C++, but I don't think that is a behavior we should replicate since it is hard to ensure reliable cross platform behavior. Any users of such conventions will have to migrate. |
@ddunbar Do you think anything else is pending or can this be marked resolved now? |
This is done. |
Comment by Myke Olson (JIRA) @swift-ci create |
1 similar comment
Comment by Myke Olson (JIRA) @swift-ci create |
Comment by Myke Olson (JIRA) Need to sync to radar and I can't modify the radar URL field when it's closed. Will close again in a minute. |
Additional Detail from JIRA
md5: a6425fbc57ea02e8b07460cffe6cd25b
Issue Description:
Implement the Package Manager C Language Target Support proposal:
https://github.com/apple/swift-evolution/blob/master/proposals/0038-swiftpm-c-language-targets.md
The text was updated successfully, but these errors were encountered: