@swift-ci create

Comment by Benedikt Terhechte (JIRA)

When I use a current developer snapshot from swift.org, there's more information. I feel like the problem might be that the "annotated" version of "document_create" (Document.init) returns type Document while the original C FFI version returned UnsafeMutablePointer<Document>?

SIL verification failed: branch argument types do not match arguments for dest bb: std::equal(BI->getArgs().begin(), BI->getArgs().end(), BI->getDestBB()->args_begin(), [&](SILValue branchArg, SILArgument *bbArg) { return verifyBranchArgs(branchArg, bbArg); })
Verifying instruction:
%9 = enum $Optional<UnsafeMutablePointer<Document>>, #Optional.some!enumelt.1, %8 : $UnsafeMutablePointer<Document> // user: %10
-> br bb3(%9 : $Optional<UnsafeMutablePointer<Document>>) // id: %10
In function:
// AppDelegate.applicationDidFinishLaunching(_🙂
sil @$S14ExplodeExample11AppDelegateC29applicationDidFinishLaunchingyy10Foundation12NotificationVF : $@convention(method) (@in_guaranteed Notification, @guaranteed AppDelegate) -> () {
// %0 // user: %2
// %1 // users: %51, %33, %24, %20, %19, %15, %14, %3
bb0(%0 : $*Notification, %1 : $AppDelegate):
debug_value_addr %0 : $*Notification, let, name "aNotification", argno 1 // id: %2
debug_value %1 : $AppDelegate, let, name "self", argno 2 // id: %3
%4 = metatype $@thin Document.Type
// function_ref document_create
%5 = function_ref @document_create : $@convention(c) () -> Optional<UnsafeMutablePointer<Document>> // user: %6
%6 = apply %5() : $@convention(c) () -> Optional<UnsafeMutablePointer<Document>> // user: %7
switch_enum %6 : $Optional<UnsafeMutablePointer<Document>>, case #Optional.someenumelt: bb2 // id: %7

// %8 // user: %9
bb1(%8 : $UnsafeMutablePointer<Document>): // Preds: bb0
%9 = enum $Optional<UnsafeMutablePointer<Document>>, #Optional.some!enumelt.1, %8 : $UnsafeMutablePointer<Document> // user: %10
br bb3(%9 : $Optional<UnsafeMutablePointer<Document>>) // id: %10

bb2: // Preds: bb0
%11 = enum $Optional<Document>, #Optional.none!enumelt // user: %12
br bb3(%11 : $Optional<Document>) // id: %12

// %13 // user: %15
bb3(%13 : $Optional<Document>): // Preds: bb2 bb1
%14 = class_method %1 : $AppDelegate, #AppDelegate.document!setter.1 : (AppDelegate) -&gt; (Document?) -&gt; (), $@convention(method) (Optional<Document>, @guaranteed AppDelegate) -> () // user: %15
%15 = apply %14(%13, %1) : $@convention(method) (Optional<Document>, @guaranteed AppDelegate) -> ()
%16 = alloc_stack $Builtin.UnsafeValueBuffer // users: %58, %54, %40, %36, %20
%17 = alloc_stack $Optional<Document> // users: %57, %39, %18
%18 = address_to_pointer %17 : $*Optional<Document> to $Builtin.RawPointer // user: %20
%19 = class_method %1 : $AppDelegate, #AppDelegate.document!materializeForSet.1 : (AppDelegate) -&gt; (Builtin.RawPointer, inout Builtin.UnsafeValueBuffer) -&gt; (Builtin.RawPointer, Builtin.RawPointer?), $@convention(method) (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @guaranteed AppDelegate) -> (Builtin.RawPointer, Optional<Builtin.RawPointer>) // user: %20
%20 = apply %19(%18, %16, %1) : $@convention(method) (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @guaranteed AppDelegate) -> (Builtin.RawPointer, Optional<Builtin.RawPointer>) // users: %22, %21
%21 = tuple_extract %20 : $(Builtin.RawPointer, Optional<Builtin.RawPointer>), 0 // user: %23
%22 = tuple_extract %20 : $(Builtin.RawPointer, Optional<Builtin.RawPointer>), 1 // users: %47, %29
%23 = pointer_to_address %21 : $Builtin.RawPointer to [strict] $*Optional<Document> // user: %24
%24 = mark_dependence %23 : $*Optional<Document> on %1 : $AppDelegate // users: %53, %42, %35, %27
%25 = integer_literal $Builtin.Int1, -1 // user: %27
%26 = integer_literal $Builtin.Int1, 0 // user: %27
%27 = select_enum_addr %24 : $*Optional<Document>, case #Optional.some!enumelt.1: %25, default %26 : $Builtin.Int1 // user: %28
cond_br %27, bb7, bb4 // id: %28

bb4: // Preds: bb3
switch_enum %22 : $Optional<Builtin.RawPointer>, case #Optional.someenumelt: bb6 // id: %29

// %30 // user: %31
bb5(%30 : $Builtin.RawPointer): // Preds: bb4
%31 = pointer_to_thin_function %30 : $Builtin.RawPointer to $@convention(method) (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @in_guaranteed AppDelegate, @thick AppDelegate.Type) -> () // user: %36
%32 = alloc_stack $AppDelegate // users: %37, %36, %33
%33 = store_borrow %1 to %32 : $*AppDelegate
%34 = metatype $@thick AppDelegate.Type // user: %36
%35 = address_to_pointer %24 : $*Optional<Document> to $Builtin.RawPointer // user: %36
%36 = apply %31(%35, %16, %32, %34) : $@convention(method) (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @in_guaranteed AppDelegate, @thick AppDelegate.Type) -> ()
dealloc_stack %32 : $*AppDelegate // id: %37
br bb6 // id: %38

bb6: // Preds: bb5 bb4
dealloc_stack %17 : $*Optional<Document> // id: %39
dealloc_stack %16 : $*Builtin.UnsafeValueBuffer // id: %40
br bb11 // id: %41

bb7: // Preds: bb3
%42 = unchecked_take_enum_data_addr %24 : $*Optional<Document>, #Optional.some!enumelt.1 // user: %46
// function_ref @objc documentCallback(step:location:length:document🙂
%43 = function_ref @$S14ExplodeExample16documentCallback4step8location6length0C0ySo9StyleStepV_S2iSvSgtFTo : $@convention(c) (StyleStep, Int, Int, Optional<UnsafeMutableRawPointer>) -> () // user: %44
%44 = enum $Optional&lt;@convention(c) (StyleStep, Int, Int, Optional&lt;UnsafeMutableRawPointer&gt;) -&gt; ()&gt;, #Optional.some!enumelt.1, %43 : $@convention(c) (StyleStep, Int, Int, Optional<UnsafeMutableRawPointer>) -> () // user: %46
// function_ref document_register_callback
%45 = function_ref @document_register_callback : $@convention(c) (@inout Document, Optional<@convention(c) (StyleStep, Int, Int, Optional<UnsafeMutableRawPointer>) -> ()>) -> () // user: %46
%46 = apply %45(%42, %44) : $@convention(c) (@inout Document, Optional<@convention(c) (StyleStep, Int, Int, Optional<UnsafeMutableRawPointer>) -> ()>) -> ()
switch_enum %22 : $Optional<Builtin.RawPointer>, case #Optional.someenumelt: bb9 // id: %47

// %48 // user: %49
bb8(%48 : $Builtin.RawPointer): // Preds: bb7
%49 = pointer_to_thin_function %48 : $Builtin.RawPointer to $@convention(method) (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @in_guaranteed AppDelegate, @thick AppDelegate.Type) -> () // user: %54
%50 = alloc_stack $AppDelegate // users: %55, %54, %51
%51 = store_borrow %1 to %50 : $*AppDelegate
%52 = metatype $@thick AppDelegate.Type // user: %54
%53 = address_to_pointer %24 : $*Optional<Document> to $Builtin.RawPointer // user: %54
%54 = apply %49(%53, %16, %50, %52) : $@convention(method) (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @in_guaranteed AppDelegate, @thick AppDelegate.Type) -> ()
dealloc_stack %50 : $*AppDelegate // id: %55
br bb9 // id: %56

bb9: // Preds: bb8 bb7
dealloc_stack %17 : $*Optional<Document> // id: %57
dealloc_stack %16 : $*Builtin.UnsafeValueBuffer // id: %58
%59 = tuple () // user: %60
%60 = enum $Optional&lt;()&gt;, #Optional.some!enumelt.1, %59 : $() // user: %61
br bb10(%60 : $Optional<()>) // id: %61

bb10(%62 : $Optional<()>): // Preds: bb11 bb9
%63 = tuple () // user: %64
return %63 : $() // id: %64

bb11: // Preds: bb6
%65 = enum $Optional<()>, #Optional.none!enumelt // user: %66
br bb10(%65 : $Optional<()>) // id: %66
} // end sil function '$S14ExplodeExample11AppDelegateC29applicationDidFinishLaunchingyy10Foundation12NotificationVF'

0 swift 0x00000001068766e8 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 40
1 swift 0x0000000106875927 llvm::sys::RunSignalHandlers() + 39
2 swift 0x0000000106876d62 SignalHandler(int) + 258
3 libsystem_platform.dylib 0x00007fff6278ff5a _sigtramp + 26
4 libsystem_platform.dylib 0x000000010c397608 _sigtramp + 2847962824
5 libsystem_c.dylib 0x00007fff6252d1ae abort + 127
6 swift 0x0000000103d9bd7d (anonymous namespace)::SILVerifier::require(bool, llvm::Twine const&, std::_1::function<void ()> const&) + 509
7 swift 0x0000000103db0add swift::SILInstructionVisitor<(anonymous namespace)::SILVerifier, void>::visit(swift::SILInstruction*) + 68653
8 swift 0x0000000103d9e08c (anonymous namespace)::SILVerifier::visitSILBasicBlock(swift::SILBasicBlock*) + 1372
9 swift 0x0000000103d98347 swift::SILFunction::verify(bool) const + 8487
10 swift 0x000000010378bb1d swift::Lowering::SILGenModule::postEmitFunction(swift::SILDeclRef, swift::SILFunction*) + 205
11 swift 0x0000000103793b1e swift::Lowering::SILGenModule::emitFunction(swift::FuncDecl*)::$_1::operator()(swift::SILFunction*) const + 318
12 swift 0x000000010378b536 swift::Lowering::SILGenModule::emitFunction(swift::FuncDecl*) + 774
13 swift 0x00000001038661c5 (anonymous namespace)::SILGenType::visitFuncDecl(swift::FuncDecl*) + 21
14 swift 0x0000000103864713 (anonymous namespace)::SILGenType::emitType() + 163
15 swift 0x0000000103864669 swift::Lowering::SILGenModule::visitNominalTypeDecl(swift::NominalTypeDecl*) + 25
16 swift 0x00000001037905bb swift::Lowering::SILGenModule::emitSourceFile(swift::SourceFile*, unsigned int) + 795
17 swift 0x0000000103791358 swift::SILModule::constructSIL(swift::ModuleDecl*, swift::SILOptions&, swift::FileUnit*, llvm::Optional<unsigned int>, bool) + 344
18 swift 0x000000010379195f swift::performSILGeneration(swift::FileUnit&, swift::SILOptions&, llvm::Optional<unsigned int>) + 95
19 swift 0x000000010305f25f performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) + 8655
20 swift 0x000000010305c072 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2946
21 swift 0x00000001030169ee main + 1134
22 libdyld.dylib 0x00007fff62481015 start + 1
23 libdyld.dylib 0x0000000000000047 start + 2646077491

Oh, that's definitely possible, yeah. Initializers should always return the actual type directly. I guess the compiler should check for this, but it's not critical, then.

Comment by Brian (JIRA)

We started running into this exception intermittently on our archive builds. It occurs on Xcode 12.5.1 and Xcode 13 beta 5. It started when we introduced `some OurProtocol`, instead of returning concrete types. It only started happening about a month after we started using `some`, and it occurs with only one of our types. It appears that if the type is generic, it's fine - even just adding an un-used generic parameter fixes the issue currently. If the code is moved into a different module, the issue goes away (The module it is in also defines the protocol, which may be the differentiator).

Unfortunately it will be a bit challenging to create a reproducible project.

{{ PHI node operands are not the same type as the result!
%23 = phi %T8HopperUI14StackViewThreeCyAA08OptionalD0CyAA5LabelCGAA09WithLayerD0CyAA5EntryO09TextFieldD0CGAHG* [ %21, %20 ], 47832
in function $s8HopperUI26PartialDesignRepresentablePAAE9configure4view7contexty0D5Model_4ViewQZ_AA0J7ContextVtFyxcfU_AA09SearchBarD0V_Tg5
<unknown>:0: error: fatal error encountered during compilation; please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project
<unknown>:0: note: Broken function found, compilation aborted!
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
Stack dump:
0. Running pass 'Module Verifier' on function '@"$s8HopperUI26PartialDesignRepresentablePAAE9configure4view7contexty0D5Model_4ViewQZ_AA0J7ContextVtFyxcfU_AA09SearchBarD0V_Tg5"'
0 swift-frontend 0x0000000113191e85 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 37
1 swift-frontend 0x0000000113190e78 llvm::sys::RunSignalHandlers() + 248
2 swift-frontend 0x0000000113192446 SignalHandler(int) + 262
3 libsystem_platform.dylib 0x00007fff204e9d7d _sigtramp + 29
4 libsystem_platform.dylib 0x0000000000001bbb _sigtramp + 18446603339974147675
5 libsystem_c.dylib 0x00007fff203f9406 abort + 125
6 swift-frontend 0x000000010e3b4a31 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*)::$1::invoke(void*, std::1::basic_string<char, std::1::char_traits<char>, std::_1::allocator<char> > const&, bool) + 1169
7 swift-frontend 0x00000001130e72d0 llvm::report_fatal_error(llvm::Twine const&, bool) + 288
8 swift-frontend 0x00000001130e71ab llvm::report_fatal_error(char const*, bool) + 43
9 swift-frontend 0x000000011308737f (anonymous namespace)::VerifierLegacyPass::runOnFunction(llvm::Function&) + 111
10 swift-frontend 0x00000001130210b9 llvm::FPPassManager::runOnFunction(llvm::Function&) + 1353
11 swift-frontend 0x00000001130203a0 llvm::legacy::FunctionPassManagerImpl::run(llvm::Function&) + 112
12 swift-frontend 0x0000000113027835 llvm::legacy::FunctionPassManager::run(llvm::Function&) + 341
13 swift-frontend 0x000000010e7603e8 swift::performLLVMOptimizations(swift::IRGenOptions const&, llvm::Module*, llvm::TargetMachine*) + 1688
14 swift-frontend 0x000000010e761486 swift::performLLVM(swift::IRGenOptions const&, swift::DiagnosticEngine&, llvm::sys::SmartMutex<false>, llvm::GlobalVariable, llvm::Module*, llvm::TargetMachine*, llvm::StringRef, swift::UnifiedStatsReporter*) + 2582
15 swift-frontend 0x000000010e76ef9f (anonymous namespace)::LLVMCodeGenThreads::Thread::run() + 191
16 swift-frontend 0x000000010e76eed9 (anonymous namespace)::LLVMCodeGenThreads::runThread(void*) + 9
17 libsystem_pthread.dylib 0x00007fff204a48fc _pthread_start + 224
18 libsystem_pthread.dylib 0x00007fff204a0443 thread_start + 15
error: Abort trap: 6 (in target 'HopperUI' from project 'HopperUI')
}}