Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-8340] Protocol var and subscript "must have explicit { get } or { get set }" could be improved #50868

Closed
Dante-Broggi opened this issue Jul 22, 2018 · 1 comment
Closed

[SR-8340] Protocol var and subscript "must have explicit { get } or { get set }" could be improved #50868

Dante-Broggi opened this issue Jul 22, 2018 · 1 comment
Labels
compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation good first issue Good for newcomers improvement parser Area → compiler: The legacy C++ parser

Comments

@Dante-Broggi
Copy link
Contributor

Previous ID SR-8340
Radar None
Original Reporter @Dante-Broggi
Type Improvement
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, DiagnosticsQoI, Parser, StarterBug
Assignee mzp (JIRA)
Priority Medium

md5: 1e1338006ac9b7751843c0d48c69d16f

Issue Description:

Consider:

protocol P {
  var v : Bool // No fixit - "Property in protocol must have explicit { get } or { get set } specifier" 
  subscript() -> Bool // fixit: " { get set }" - "Subscript in protocol must have explicit { get } or { get set } specifier"
}

I think both should have the same fixit, and it should probably be:

{ get <#set#>}
@swift-ci
Copy link
Collaborator

swift-ci commented Oct 2, 2018

Comment by MIZUNO Hiroki (JIRA)

Send PR: #19660

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation good first issue Good for newcomers improvement parser Area → compiler: The legacy C++ parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swift-ci @Dante-Broggi