[SR-8542] Setting OperationQueue.name sets OperationQueue.underlyingQueue to nil #3646
Assignees
Labels
Comments
|
This isnt a 4.2 regression, NSOQ's implementation could use some sprucing up particularly in the regards to things like this. |
|
This is fixed in 5.1 $ sr-8542.swift
import Foundation
let queue = DispatchQueue(label: "org.swift.queue")
let opqueue = OperationQueue()
opqueue.underlyingQueue = queue
opqueue.name = "foo"
precondition(opqueue.underlyingQueue === queue, "Should be same!")
print("PASS")
$ ~/swift-5.1.5-RELEASE-ubuntu18.04/usr/bin/swift sr-8542.swift
PASS
|
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional Detail from JIRA
md5: 5c53b69249fa5d38ca9db24d2a2ed252
Issue Description:
Please copy/paste this code into queue.swift file and compile:
import Foundation
let queue = DispatchQueue(label: "org.swift.queue")
let opqueue = OperationQueue()
opqueue.underlyingQueue = queue
opqueue.name = "foo"
precondition(opqueue.underlyingQueue === queue, "Should be same!")
print("PASS")
The precondition fails on Ubuntu 16.04 with Swift 4.2-CONVERGENCE build. Passes on Darwin with the same swift toolchain.
The issue seems to be here:
https://github.com/apple/swift-corelibs-foundation/blob/swift-4.2-branch/Foundation/Operation.swift
Around line 529.
This was introduced in this commit:
bc3abbf
The text was updated successfully, but these errors were encountered: