Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9442] benchmark/Benchmark_Driver.test-sh is failing #51906

Closed
eeckstein opened this issue Dec 7, 2018 · 4 comments
Closed

[SR-9442] benchmark/Benchmark_Driver.test-sh is failing #51906

eeckstein opened this issue Dec 7, 2018 · 4 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself

Comments

@eeckstein
Copy link
Member

Previous ID SR-9442
Radar rdar://problem/46565291
Original Reporter @eeckstein
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug
Assignee @palimondo
Priority Medium

md5: 032fe3baf205c97ea90159c065458961

Issue Description:

See https://ci.swift.org/job/oss-swift-incremental-RA-osx/5935/

It started failing one build after #20861 (comment) was merged. Looks like it's a flaky test.

Arnold disabled the test for now.

@eeckstein
Copy link
Member Author

Pavol, can you please take a look?

@palimondo
Copy link
Mannequin

palimondo mannequin commented Dec 8, 2018

I see what the issue is: It expects to see Ackermann in the output, but if the check passes without any issues, which it now should, the test fails.

I specifically ran full `test` before merging, so I'm curious why it didn't fail than…

The fix is to add --verbose flag, to always see Ackermann in the output, as the point of this integration test is just to see the python script doesn't crash when invoking the driver:

// RUN: %Benchmark_Driver check 1 --verbose \

@eeckstein aschwaighofer@apple.com (JIRA User) Can you guys do that for of me, please? I'm running a full compilation overnight at the moment (it's 1:50am here).

UPDATE: Ups… it does crash (when I ran this locally with what I had left over in my bin...) So if the above doesn't really help, I'll investigate tomorrow.
I was crashing locally because build has already wiped the libraries... The above should be the fix. I apparently need to sleep.

@palimondo
Copy link
Mannequin

palimondo mannequin commented Dec 8, 2018

#21150

and

#21166

@palimondo
Copy link
Mannequin

palimondo mannequin commented Dec 10, 2018

@eeckstein please update the radar.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself
Projects
None yet
Development

No branches or pull requests

1 participant