Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9699] Project Swift Foundation Pull Request Test Linux doesnt build ICU #3555

Closed
spevans opened this issue Jan 18, 2019 · 4 comments
Closed

[SR-9699] Project Swift Foundation Pull Request Test Linux doesnt build ICU #3555

spevans opened this issue Jan 18, 2019 · 4 comments
Assignees
@shahmishal
Labels
bug Foundation

Comments

@spevans
Copy link
Collaborator

spevans commented Jan 18, 2019

Previous ID SR-9699
Radar None
Original Reporter @spevans
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Foundation, Project Infrastructure
Labels Bug
Assignee @shahmishal
Priority Medium

Watchers: @shahmishal

md5: 4435cbddc26a87e6a728ce205cf18a12

Issue Description:

When the CI tests for Foundation PRs are run the script is run with the following options:

swift/utils/build-script -R -T --llbuild --swiftpm --xctest --debug-foundation --libdispatch – --reconfigure --lit-args=-v

This is not building libICU which is falling back to the system one. The --libicu argument needs to be added to fix this

So the full command line should be:

swift/utils/build-script -R -T -libicu -llbuild --swiftpm --xctest --debug-foundation --libdispatch – --reconfigure --lit-args=-v

The change can be tested by running swift-ci test on #1830

Note: this only affects the PR testing for Foundation, the snapshots are building correctly as the buildbot preset is used.
@spevans
Copy link
Collaborator Author

spevans commented Jan 18, 2019

cc @shahmishal @millenomi

@shahmishal
Copy link
Member

Updated the pull request job to use --libicu

@spevans
Copy link
Collaborator Author

spevans commented Feb 15, 2019

Thanks - tested ok

@spevans
Copy link
Collaborator Author

spevans commented Feb 19, 2019

@shahmishal Unfortunately this fix breaks the 4.2 testing since that flag should not be used on swift-4.2-branch

Could you possibly setup a custom 4.2 test for swift-corelibs-foundation for Linux like you did for macOS which doesnt have the --libicu flag and tie it into the swift-ci test 4.2 test? But keep it on the master and swift-5.0-branch.

#1930 can be used as a test case once its fixed.

Sorry for all the confusion

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahmishal shahmishal

Labels
bug Foundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spevans @shahmishal