Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9807] Swift 5: KeyPath<Subclass, V> crashes for let properties inherited from superclass #52227

Closed
swift-ci opened this issue Jan 30, 2019 · 2 comments
Closed

[SR-9807] Swift 5: KeyPath<Subclass, V> crashes for let properties inherited from superclass #52227

swift-ci opened this issue Jan 30, 2019 · 2 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself crash Bug: A crash, i.e., an abnormal termination of software key paths Feature: key paths (both native and Objective-C) run-time crash Bug → crash: Swift code crashed during execution

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-9807
Radar None
Original Reporter johnestropia (JIRA User)
Type Bug
Status Resolved
Resolution Done
Environment

Swift 5 (Xcode 10.2 beta (10P82s))

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, KeyPaths, RunTimeCrash
Assignee None
Priority Medium

md5: 1f598435ac9c59fb6c9daccbf4a3291c

Issue Description:

To illustrate the issue, here is a "working" example: (note use of var)

class Base {
    var val: String = "string"
}
class Sub: Base {}

let object = Sub()
print(object[keyPath: \Base.val]) // "string"
print(object[keyPath: \Sub.val]) // "string"

Making the property let instead causes a runtime crash on the \Sub.val access:

class Base {
    let val: String = "string"
}
class Sub: Base {}

let object = Sub()
print(object[keyPath: \Base.val]) // "string"
print(object[keyPath: \Sub.val]) // Crash!

The latter example runs fine on Swift 4.2 but breaks on Swift 5.
@belkadan
Copy link
Contributor

@jckarter, I seem to remember something being broken about inherited key paths in 4.2; maybe the fix turned around and busted this?

@swift-ci
Copy link
Collaborator Author

Comment by John Estropia (JIRA)

Confirmed unreproducible as of the Swift 5 release (Xcode 10.2)

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added the crash Bug: A crash, i.e., an abnormal termination of software label Dec 12, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself crash Bug: A crash, i.e., an abnormal termination of software key paths Feature: key paths (both native and Objective-C) run-time crash Bug → crash: Swift code crashed during execution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@belkadan @swift-ci @AnthonyLatsis