Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9863] Libdispatch's semaphores mishandle exits due to signals #623

Open
swift-ci opened this issue Feb 4, 2019 · 2 comments
Open

[SR-9863] Libdispatch's semaphores mishandle exits due to signals #623

swift-ci opened this issue Feb 4, 2019 · 2 comments
Labels
bug libdispatch

Comments

@swift-ci
Copy link

swift-ci commented Feb 4, 2019

Previous ID SR-9863
Radar rdar://problem/47791327
Original Reporter gmilos (JIRA User)
Type Bug

Attachment: Download

Additional Detail from JIRA
Votes 0
Component/s libdispatch
Labels Bug
Assignee ktopley-apple (JIRA)
Priority Medium

md5: e78b5ae6fce74b3d638d2adebfa603b3

Issue Description:

The attached reproduction shows how libdispatch semaphore crashes if the process is configured to receive a signal (non-default).

This is due to unguarded sem_wait:

swift-corelibs-libdispatch/src/shims/lock.c

Line 206 in dde5892

int ret = sem_wait(sema);

@swift-ci
Copy link
Author

swift-ci commented Feb 4, 2019

Comment by Gregor Milos (Grzegorz Miłoś) (JIRA)

Proposed fix:
#442

Assigning to Daniel for review/merge.

@swift-ci
Copy link
Author

swift-ci commented Feb 4, 2019

Comment by Daniel A. Steffen (JIRA)

lgtm, approved the PR, I'll let Kim merge

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug libdispatch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swift-ci