Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-9875] Optimizer's inlining heuristics introducing instability #52281

Open
milseman mannequin opened this issue Feb 6, 2019 · 1 comment
Open

[SR-9875] Optimizer's inlining heuristics introducing instability #52281

milseman mannequin opened this issue Feb 6, 2019 · 1 comment
Assignees
@atrick
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself performance

Comments

@milseman
Copy link
Mannequin

milseman mannequin commented Feb 6, 2019

Previous ID SR-9875
Radar None
Original Reporter @milseman
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, Performance
Assignee @atrick
Priority Medium

md5: b03fec7ea1343545247897459f29f7ec

Issue Description:

When we optimize the standard library code, by deleting lots of branches, optimizer heuristics can cause slowdowns. These block the efforts to delete lots of branches.

#21132 (comment)
#22338
@atrick
Copy link
Member

atrick commented Feb 6, 2019

Regressions from #21132 (comment)
Breadcrumbs.CopyUTF16CodeUnits.Mixed 55 65 +18.2% 0.85x
IterateData 1403 1562 +11.3% 0.90x

Regressions from #22338
CharIndexing_tweet_unicodeScalars 11280 12760 +13.1% 0.88x
CharIndexing_ascii_unicodeScalars 5760 6480 +12.5% 0.89x
CharIndexing_punctuated_unicodeScalars 1440 1600 +11.1% 0.90x
CharIndexing_chinese_unicodeScalars 5400 5960 +10.4% 0.91x ❓
CharIndexing_japanese_unicodeScalars 8800 9680 +10.0% 0.91x
CharIndexing_korean_unicodeScalars 7120 7800 +9.6% 0.91x
CharIndexing_punctuatedJapanese_unicodeScalars 1440 1560 +8.3% 0.92x

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atrick atrick

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atrick