Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-6136] foundation project should include CFFileDescriptor header #4405

Open
swift-ci opened this issue Oct 12, 2017 · 1 comment
Open

[SR-6136] foundation project should include CFFileDescriptor header #4405

swift-ci opened this issue Oct 12, 2017 · 1 comment
Labels
bug Foundation

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-6136
Radar None
Original Reporter efx (JIRA User)
Type Bug
Additional Detail from JIRA
Votes 3
Component/s Foundation
Labels Bug
Assignee None
Priority Medium

md5: cbaa5e6f3681f719038d08e3aa3551b9

duplicates:

  • SR-8741 Include CFFileDescriptor in public CoreFoundation source drop

Issue Description:

https://github.com/apple/swift-corelibs-foundation/blob/master/CoreFoundation/Stream.subproj/CFConcreteStreams.c refers to CFFileDescriptor but does not define it.

This same is true of all the old CF releases on opensource.apple.com
This has caused a bug in when using a nix compiled version of watchman . See NixOS/nixpkgs#14309 (comment) for summary of that issue.
@swift-ci
Copy link
Contributor Author

Comment by Dan Peebles (JIRA)

To be clear, CFConcreteStreams.c compiles because presumably REAL_FILE_SCHEDULING is unset, but it seems a bit awkward to include code that won't work without private headers, especially if those headers are available in the public SDK.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Foundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swift-ci